Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencv4] build failure #38557

Closed
nickanthony-dgl opened this issue May 3, 2024 · 4 comments
Closed

[opencv4] build failure #38557

nickanthony-dgl opened this issue May 3, 2024 · 4 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@nickanthony-dgl
Copy link

Operating system

Windows 10

Compiler

MSVC

Steps to reproduce the behavior

When installing opencv4 without default features (`vcpkg install opencv4[core]`) it will fail during configuration because CMake will try to find flatbuffers. Since flatbuffers is not a dependency of opencv4 when default features are not enabled it will not be found and configuration will fail.

This issue occurs on version 4.8.0, port versions: 16-18. Port version 15 appears to work correctly.

Probably because the "fix-no-flatbuffers" patch was introduced in version 16

Failure logs

This shows the configuration failure when building on the most recent port version (18):
config-x64-win-llvm-release-out (2).log

Additional context

No response

@nickanthony-dgl nickanthony-dgl added the category:port-bug The issue is with a library, which is something the port should already support label May 3, 2024
@FrankXie05
Copy link
Contributor

@nickanthony-dgl Thanks for posting this issue, teh default functionality ensures that basic functionality is provided when the library is installed, making it easier for users to start using the library without worrying about missing necessary functionality.
https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/concepts/default-features.md

@FrankXie05 FrankXie05 added category:question This issue is a question and removed category:port-bug The issue is with a library, which is something the port should already support labels May 6, 2024
@nickanthony-dgl
Copy link
Author

So you're telling me it's intentional opencv4 should fail to build without default features?

@dg0yt
Copy link
Contributor

dg0yt commented May 6, 2024

So you're telling me it's intentional opencv4 should fail to build without default features?

It must not fail without default features. category:port-bug The issue is with a library, which is something the port should already support .

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support and removed category:question This issue is a question labels May 7, 2024
@nickanthony-dgl
Copy link
Author

Fixed by #38594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

3 participants