Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5-declarative port file lacks debug encapsulation #6857

Closed
heydojo opened this issue Jun 11, 2019 · 2 comments
Closed

qt5-declarative port file lacks debug encapsulation #6857

heydojo opened this issue Jun 11, 2019 · 2 comments
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@heydojo
Copy link
Contributor

heydojo commented Jun 11, 2019

https://github.com/microsoft/vcpkg/blob/master/ports/qt5-declarative/portfile.cmake

set(qt5decpath ${CURRENT_PACKAGES_DIR}/share/qt5/debug/mkspecs/modules/qt_lib_qmldevtools_private.pri)
file(READ "${qt5decpath}" _contents)
string(REPLACE [[QT.qmldevtools_private.libs = $$QT_MODULE_HOST_LIB_BASE]] [[QT.qmldevtools_private.libs = $$QT_MODULE_LIB_BASE]]  _contents "${_contents}")
file(WRITE "${qt5decpath}" "${_contents}")

Becomes:

if (NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug")
	set(qt5decpath ${CURRENT_PACKAGES_DIR}/share/qt5/debug/mkspecs/modules/qt_lib_qmldevtools_private.pri)
	file(READ "${qt5decpath}" _contents)
	string(REPLACE [[QT.qmldevtools_private.libs = $$QT_MODULE_HOST_LIB_BASE]] [[QT.qmldevtools_private.libs = $$QT_MODULE_LIB_BASE]]  _contents "${_contents}")
	file(WRITE "${qt5decpath}" "${_contents}")
endif()

If you want to use a triplet to only build release and not debug.
Otherwise vcpkg install qt5-declarative:x64-windows will fail with the message:

CMake Error at ports/qt5-declarative/portfile.cmake:10 (file):
file failed to open for reading (No such file or directory):

Please feel free to make these suggested changes to vcpkg if they solve the issue.
I am not at liberty to sign the contributors agreement, so have not proposed a merge.
Easy pickup for someone with write access to the tree IMO. ⚽️

@LilyWangL LilyWangL added the category:port-bug The issue is with a library, which is something the port should already support label Jun 12, 2019
@JackBoosY
Copy link
Contributor

Hi @heydojo, thanks for reporting this issue!
I've fixed this issue just now. Please update vcpkg and rebuild qt5-declarative.

Thanks.

@heydojo
Copy link
Contributor Author

heydojo commented Jun 28, 2019

Welcome 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

3 participants