Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rapidjson] RapidJSON_INCLUDE_DIRS needs to be patched in installed/<triplet>/share/rapidjson/RapidJSONConfig.cmake #7271

Closed
wravery opened this issue Jul 16, 2019 · 2 comments
Closed

[rapidjson] RapidJSON_INCLUDE_DIRS needs to be patched in installed/<triplet>/share/rapidjson/RapidJSONConfig.cmake #7271

wravery opened this issue Jul 16, 2019 · 2 comments
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@wravery
Copy link
Contributor

wravery commented Jul 16, 2019 •
edited
Loading

Since PR #7152, RapidJSON is getting installed with a bogus RapidJSONConfig.cmake file in the share directory. There's a block of code in portfile.cmake which is gated on VCPKG_USE_HEAD_VERSION that seems to deal with this, removing if(VCPKG_USE_HEAD_VERSION) ... endif() fixes this bug.

I can submit a PR once I get my fork synched up, or if anyone else wants to pick it up before then that's cool with me.
@wravery
Copy link
Contributor Author

wravery commented Jul 16, 2019

Here's a permalink to the block: if(VCPKG_USE_HEAD_VERSION) ... endif()

@LilyWangL LilyWangL added the category:port-bug The issue is with a library, which is something the port should already support label Jul 16, 2019
@LilyWangL LilyWangL mentioned this issue Jul 16, 2019
Merged
@LilyWangL
Copy link
Contributor

This issue has been fixed. So I am closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wravery @LilyWangL