Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpmemobj-cpp] Missing cmake targets #7632

Closed
seghcder opened this issue Aug 10, 2019 · 1 comment
Closed

[libpmemobj-cpp] Missing cmake targets #7632

seghcder opened this issue Aug 10, 2019 · 1 comment
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@seghcder
Copy link


Is your feature request related to a problem? Please describe.
LibPMemObj appears to be missing final cmake configuration to make targets available via find_pkg. Many other packages provide this info at the end of an install:

The package fmt:x86-windows provides CMake targets:
    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt fmt::fmt-header-only)

However this is missing for libpmemobj-cpp

Proposed solution
Make libpmemobj-cpp cmake targets available after vcpkg installation

Describe alternatives you've considered
Workaround is to use find_path / find_library in CMake file

Additional context
Thanks!

@seghcder seghcder added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 10, 2019
@PhoebeHui PhoebeHui self-assigned this Nov 27, 2019
@LilyWangLL
Copy link
Contributor

This issue has been fix, you can rebuild libpmemobj-cpp and use the following codes to use it.

Elapsed time to handle libpmemobj-cpp:x64-windows: 20.9 s

Total elapsed time: 28.82 s

libpmemobj-cpp is header-only and can be used from CMake via:

    find_path(LIBPMEMOBJ_CPP_INCLUDE_DIRS "libpmemobj++/allocation_flag.hpp")
    target_include_directories(main PRIVATE ${LIBPMEMOBJ_CPP_INCLUDE_DIRS})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

3 participants