Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable build qt5-base under windows #3133

Closed
alexander-smyslov opened this issue Mar 26, 2018 · 2 comments
Closed

Unable build qt5-base under windows #3133

alexander-smyslov opened this issue Mar 26, 2018 · 2 comments

Comments

@alexander-smyslov
Copy link
Contributor

Unable build qt5-base under windows

Enable fix-system-pcre2.patch again for successful build

diff --git a/ports/qt5-base/portfile.cmake b/ports/qt5-base/portfile.cmake
index 39498b4a..c398b437 100644
--- a/ports/qt5-base/portfile.cmake
+++ b/ports/qt5-base/portfile.cmake
@@ -42,7 +42,7 @@ file(REMOVE_RECURSE ${SOURCE_PATH}/include/QtZlib)
vcpkg_apply_patches(
SOURCE_PATH ${SOURCE_PATH}
PATCHES
-# "${CMAKE_CURRENT_LIST_DIR}/fix-system-pcre2.patch"

  •    "${CMAKE_CURRENT_LIST_DIR}/fix-system-pcre2.patch"
       "${CMAKE_CURRENT_LIST_DIR}/fix-system-freetype.patch"
    

)

@alexander-smyslov
Copy link
Contributor Author

@ras0219-msft Please see. I can provide more logs.

@ras0219-msft
Copy link
Contributor

Thanks a ton for catching this regression and providing the fix! I've added it back in on master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants