Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to Verona MLIR dialect #107

Closed
rengolin opened this issue May 7, 2020 · 4 comments
Closed

Conversion to Verona MLIR dialect #107

rengolin opened this issue May 7, 2020 · 4 comments
Assignees

Comments

@rengolin
Copy link
Contributor

rengolin commented May 7, 2020

With both dialect and type system designed, we can start coding the conversion infrastructure from opaque MLIR to Verona dialect. This task will probably need to occur in parallel with #105, and after #104 and #106.

We should have a series of partial conversions, with or without type inference, and finish with a pure Verona dialect (with possible embedded std/loop dialects) graph.

Acceptance criteria:

  • Write all partial conversions from opaque MLIR to Verona dialect
  • Finish with a full conversion and validate that the dialect is pure and consistent
  • Write tests for all known cases of the syntax/semantics and some larger programs

Not included:

  • Lowering to LLVM dialect
  • Optimisation passes other than required to validate
@rengolin rengolin self-assigned this May 15, 2020
@rengolin
Copy link
Contributor Author

Stub dialect inside the Verona tree with LIT test working at https://github.com/rengolin/verona/tree/mlir-ast.

So far, it reads opaque MLIR and spits out broken MLIR, but it's just a stub for the infrastructure, not the actual code logic.

The AST -> MLIR bridge will be built once we have the parser in-tree (#111), and it's also when we'll be able to start working on the dialect proper (#106).

@rengolin rengolin removed their assignment May 19, 2020
@rengolin
Copy link
Contributor Author

Putting this on hold until we have an actual AST->MLIR conversion (#117)

@rengolin
Copy link
Contributor Author

rengolin commented Aug 3, 2020

Ok, now it's time to start lowering into the Verona dialect. The first task is #203.

@rengolin rengolin self-assigned this Aug 3, 2020
@rengolin
Copy link
Contributor Author

rengolin commented Dec 7, 2020

We're moving the high level IR to a different design, only having the low-level parts in MLIR, so all of the designs in this issue are being deprecated in favour of a more modular approach.

@rengolin rengolin closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant