Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis PR build check does not use stable Ubuntu #900

Closed
PeterWone opened this issue Sep 25, 2019 · 2 comments
Closed

Travis PR build check does not use stable Ubuntu #900

PeterWone opened this issue Sep 25, 2019 · 2 comments
Assignees

Comments

@PeterWone
Copy link
Contributor

PeterWone commented Sep 25, 2019

Travis is rejecting my PR but only for Ubuntu (it passes for both Win32 and Darwin) so I built an Ubuntu VM and tooled it up until I could run the tests in VS Code.

The problem is not with VS Code or vscode-arduino, it's with the Arduino IDE which has problems on the latest Ubuntu.

I repeated the exercise with Ubuntu Stable (18.04.2) and had no problems with Arduino IDE so I finished tooling up and found that my version of vscode-arduino passes all tests.

Change testing to use Ubuntu 18.04.2

@PeterWone PeterWone changed the title Build process does not use stable Ubuntu Travis does not use stable Ubuntu Sep 25, 2019
@PeterWone PeterWone changed the title Travis does not use stable Ubuntu Travis PR test does not use stable Ubuntu Sep 25, 2019
@PeterWone PeterWone changed the title Travis PR test does not use stable Ubuntu Travis PR build check does not use stable Ubuntu Sep 25, 2019
@zunhu
Copy link

zunhu commented Sep 26, 2019

hi, yes please use ubuntu 18.04.2. not support for latest version of ubuntu yet.

@dooriya dooriya self-assigned this Sep 26, 2019
@dooriya
Copy link
Member

dooriya commented Sep 26, 2019

@PeterWone As we discussed in #869, I think this issue has already been fixed. So close it here.
Please feel free to re-open it if this issue arises again.

@dooriya dooriya closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants