Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing curly brace cannot be written #40

Open
alexdima opened this issue Oct 25, 2017 · 6 comments
Open

Closing curly brace cannot be written #40

alexdima opened this issue Oct 25, 2017 · 6 comments

Comments

@alexdima
Copy link
Member

Extracted from microsoft/vscode#36635

From @deiberdev @mnunezdm

The extension most likely binds keys to ctrl+alt+.... This should not be done, as it impairs users that use a non US keyboard layout on Windows.

e.g. Spanish keyboard layout, Latin American keyboard layout

@auchenberg
Copy link
Contributor

@deiberdev @mnunezdm I've updated the mappings for folding which seem to be the ones that collide. I don't have a non-us keyboard so you could try to pull master of this extension and help me validate?

546a547

@mnunezdm
Copy link

mnunezdm commented Nov 3, 2017

Just installed from vsix and unfortunately the issue is still here

This is my current layout

photo_2017-11-03_10-29-51

I can test later in a full desktop keyboard

@deiberchacon
Copy link

deiberchacon commented Nov 13, 2017

I've also updated the mappings (like @auchenberg in 546a547), and now I can retype the closing curly brace with ctrl+alt+} and alt+gr+}. This solution works fine.

@auchenberg
Copy link
Contributor

@mnunezdm Thanks for trying it out. Did you pull master of this repo or use the published version?

@mnunezdm
Copy link

Yes, I removed the extension, install it from the pulled version and tried it out and nothing worked

@usagi
Copy link

usagi commented Aug 11, 2020

I got the same trouble, I cannot input the } in some times. Then, I open the DevTool(> Toggle Developer Tools) and type } key in the situation. I got the ERR on my } key input timing:

ERR Cannot read property 'length' of undefined: TypeError: Cannot read property 'length' of undefined
    at Object.t.firstNonWhitespaceIndex (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:221:720)
    at Function.normalizeIndentation (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1415:974)
    at g.normalizeIndentation (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1456:466)
    at Function._runAutoIndentType (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1481:93)
    at Function.typeWithInterceptors (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1487:475)
    at file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1532:494
    at m._executeEdit (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1531:546)
    at m.type (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1532:275)
    at file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1584:829
    at y._withViewEventsCollector (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1586:518)
    at y._executeCursorEdit (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1584:431)
    at y.type (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1584:794)
    at e._type (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2295:898)
    at e.trigger (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2295:134)
    at I.runCommand (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1930:972)
    at handler (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1897:702)
    at e.handler (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1610:808)
    at d.invokeFunction (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1651:817)
    at u._tryExecuteCommand (file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3944:968)
    at file:///C:/Users/usagi/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3944:717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@usagi @auchenberg @alexdima @mnunezdm @deiberchacon and others