Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate switching to MSAL JS library #203

Open
bwateratmsft opened this issue Jul 10, 2020 · 8 comments
Open

Investigate switching to MSAL JS library #203

bwateratmsft opened this issue Jul 10, 2020 · 8 comments
Labels
feature

Comments

@bwateratmsft
Copy link
Contributor

It looks like the adal-node dependency might be one of the last ones that depends on request (which is deprecated). The Azure SDK for JS replaces it with node-fetch, looks like MSAL with axios.

It may also fix #53 according to this comment.
@fhljys
Copy link

fhljys commented Mar 16, 2021

Any update?

@albertleigh
Copy link

Any plans? 😀

@sevillal sevillal mentioned this issue Jun 10, 2021
Closed
@wwlorey wwlorey added this to the 0.10.0 milestone Jul 8, 2021
This was referenced Sep 29, 2021
Merged
Merged
Merged
Merged
Merged
@wwlorey
Copy link
Contributor

wwlorey commented Nov 11, 2021

Support for MSAL will be released in version 0.10.0 of the extension.

@wwlorey wwlorey closed this as completed Nov 11, 2021
@bwateratmsft
Copy link
Contributor Author

Woohoo!

@wwlorey wwlorey mentioned this issue Nov 15, 2021
Open
@ruiminwang
Copy link

When will 0.10.0 be released? Looking forward to the new version!

@wwlorey
Copy link
Contributor

wwlorey commented Feb 15, 2022

Support for MSAL has been released! 🎉 In v0.10.0 you can now use the Azure: Authentication Library setting to switch between ADAL and MSAL.

@bwateratmsft
Copy link
Contributor Author

I'm going to reopen this as it's active again.

@bwateratmsft bwateratmsft reopened this Aug 8, 2022
@bwateratmsft bwateratmsft removed this from the 0.10.0 milestone Aug 8, 2022
@shsuman shsuman mentioned this issue Aug 8, 2022
Closed
@tbombach tbombach mentioned this issue Sep 2, 2022
Closed
25 tasks
@tbombach tbombach mentioned this issue Oct 4, 2022
Closed
29 tasks
@tbombach tbombach mentioned this issue Nov 7, 2022
Closed
20 tasks
@shsuman shsuman mentioned this issue Dec 8, 2022
Closed
16 tasks
@scale-tone scale-tone mentioned this issue Dec 28, 2022
Closed
@shsuman
Copy link
Member

shsuman commented Jan 6, 2023

Are there any updates on this issue ?

@tbombach tbombach mentioned this issue Jan 9, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@chrisdias @RMacfarlane @fhljys @wwlorey @albertleigh @bwateratmsft @shsuman @ruiminwang