-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support validating subproperties of functions that return objects #11
Comments
It doesn't look like this level of details is supported, just the top-level return values. I.e., to add support for XXX in [template(...).properties.XXX] would require feature work. |
That was my eval as well... |
Closing this. We'll wait for more external feedback regarding this. |
What kind of feedback are you expecting? As implemented this provides no value... and I don't see much "feedback" around other issues that are being addressed, so I'm confused as to what the bar is here. |
It's a question of priorities and resources. If customers need this kind of supports deeper into the tree than we currently support, and indicate so via feedback, we'll consider adding it. But it would not be cheap to add it, and I'd say there are more important things. |
How are we prioritizing? I'm not seeing much feedback on a number of other items flowing through the repo either, but those are still being done. Perhaps "Future" is a better way to direct this than dismissing it. |
See: https://github.com/Microsoft/vscode-azurearmtools/blob/master/assets/ExpressionMetadata.json#L108
The return members on the function are:
name
properties
And then the properties object contains these return members
properties.template
properties.templateLink
properties.parameters
properties.mode
properties.provisioningState
and some of those members also have children, see: https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-template-functions-deployment#deployment
Not sure if the extension supports it or how to author that in the expression metadata so I'm going to submit a PR to just fix the top level members... Use this issue to track the remaining corrections.
The text was updated successfully, but these errors were encountered: