Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node model v4: AppSetting validation #3559

Closed
horihiro opened this issue Feb 6, 2023 · 2 comments · Fixed by #3653
Closed

Node model v4: AppSetting validation #3559

horihiro opened this issue Feb 6, 2023 · 2 comments · Fixed by #3653
Assignees
@nturinski
Labels
node programming model

Comments

@horihiro
Copy link

horihiro commented Feb 6, 2023

It might be good for developers to validate if AppSetting AzureWebJobsFeatureFlags has EnableWorkerIndexing when deploying functions of Node model v4.
@ejizba
Copy link
Member

ejizba commented Feb 6, 2023

Hi @horihiro the app setting will no longer be necessary in the near future. This was fixed in the functions host in Azure/azure-functions-host#8864 and will be rolling out soon (for sure before we announce public preview). With that in mind, I don't think it's worth implementing validation in VS Code

@ejizba ejizba closed this as completed Feb 6, 2023
@ejizba
Copy link
Member

ejizba commented Mar 22, 2023

Unfortunately the host team had to revert the flag change because they ran into some issues Azure/azure-functions-host#9163. I don't know when they will be able to revert the revert, so might be worth considering this enhancement. Fyi @nturinski

@ejizba ejizba reopened this Mar 22, 2023
@nturinski nturinski self-assigned this Mar 31, 2023
@nturinski nturinski mentioned this issue Apr 21, 2023
Merged
@ejizba ejizba mentioned this issue May 3, 2023
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nturinski nturinski

Labels
node programming model
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify feature flag and enable prior to deployment microsoft/vscode-azurefunctions
3 participants
@horihiro @nturinski @ejizba