Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent #185

Closed
StephenWeatherford opened this issue Jun 27, 2018 · 2 comments
Closed

Add user agent #185

StephenWeatherford opened this issue Jun 27, 2018 · 2 comments
Labels
Milestone

Comments

@StephenWeatherford
Copy link
Contributor

microsoft/vscode-azuretools#200

@StephenWeatherford StephenWeatherford added this to the 0.5.0 milestone Jun 30, 2018
@PrashanthCorp
Copy link
Contributor

Need to verify that it's fully implemented.

@PrashanthCorp
Copy link
Contributor

Currently among the clients we can create, we only create a StorageManagementClient. I verified that we use createAzureClient<T> whenever we create a client of type T. This directly adds the extension user agent. This is similar to how other extensions do it.

Closing this.

Question: This feels like a probable issue every time there's new code using an azure client. If the author forgets to wrap it in a createAzureClient call, we would not have the user agent info.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants