Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black extension shouldn't remove semi-colons when formatting Notebooks #188

Closed
nickeubank opened this issue Feb 20, 2023 · 1 comment
Closed
Assignees
Labels
triage-needed Issue is not triaged.

Comments

@nickeubank
Copy link

Currently when run against Notebooks, the ms black extension removes semi-colons. But in Jupyter notebooks, a semi-colon has meaning—it tells the notebook to not print the output from that line (as it normally would by default for the last line in a cell). When writing notebooks for instruction, this can be annoying.

An example of where this comes up—note after running black on the notebook, I have to go back and re-add in ; to prevent several hundred line outputs.

Note that Black itself respects semi-colons when formatting notebooks, the problem seems specific to the ms extension

@github-actions github-actions bot added the triage-needed Issue is not triaged. label Feb 20, 2023
@karthiknadig karthiknadig self-assigned this Feb 21, 2023
@karthiknadig
Copy link
Member

Closing this in favor of #87

Currently we are blocked on openlawlibrary/pygls#311 to provide full notebooks support in the extension.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-needed Issue is not triaged.
Projects
None yet
Development

No branches or pull requests

2 participants