Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useCMakeServer option no longer respected #1059

Closed
OXINARF opened this issue Feb 10, 2020 · 9 comments
Closed

useCMakeServer option no longer respected #1059

OXINARF opened this issue Feb 10, 2020 · 9 comments
Labels
Feature: settings fixed (release pending) fixed in pre-release and is pending official release
Milestone

Comments

@OXINARF
Copy link

OXINARF commented Feb 10, 2020

Brief Issue Summary

The useCMakeServer option is no longer respected, although it is still a valid option.

Expected:

Either the option is removed (and, if currently set to false, it is transitioned to "legacy" in the new cmakeCommunicationMode option) or the option is respected.

Platform and Versions

  • Operating System: Windows, with SSH extension on Linux
  • CMake Version: 3.10.3
  • VSCode Version: 1.42.0
  • CMake Tools Extension Version: 1.3.0
  • Compiler/Toolchain: GCC 7.4.0
@andreeis andreeis added this to the 1.4.0 milestone Feb 10, 2020
@andreeis
Copy link
Contributor

We deprecated the useCMakeServer setting in release 1.3.0 and we are going to remove it completely in 1.4.
However, it should still work. What is the scenario when it is not respected?

@OXINARF
Copy link
Author

OXINARF commented Feb 22, 2020

@andreeis Sorry for the delay in getting back to you.

We deprecated the useCMakeServer setting in release 1.3.0

Is that documented anywhere? I couldn't find it but maybe I missed it.

However, it should still work. What is the scenario when it is not respected?

I had useCMakeServer set to false and that's not respected anymore.

Looking at the change that introduced File API (0b55e5b), it shows that "conversion" is only done when useCMakeServer is set to true, which doesn't make much sense since that was the default before 1.3.0...

@bobbrow
Copy link
Member

bobbrow commented Feb 24, 2020

Yes, it was an oversight. We'd be interested to understand why you prefer legacy mode over server and file api modes though.

@OXINARF
Copy link
Author

OXINARF commented Feb 25, 2020

@bobbrow Not exactly my choice. I'm using a SDK and the included CMake doesn't support file API and server mode gives an error (I couldn't find out exactly why).

@bobbrow
Copy link
Member

bobbrow commented Feb 25, 2020

Is the SDK available online, or is it proprietary?

@OXINARF
Copy link
Author

OXINARF commented Feb 25, 2020

Unfortunately it's proprietary. I'm not sure it is CMake Tools fault that server mode doesn't work, but I couldn't find a log that said what command it is trying to run - is it written somewhere?

@bobbrow
Copy link
Member

bobbrow commented Feb 25, 2020

You can enable trace logging with the cmake.loggingLevel setting. And then logs will appear in the Output Window when you select the "CMake/Build" channel in the dropdown box.

@bobbrow bobbrow added the fixed (release pending) fixed in pre-release and is pending official release label May 7, 2020
@andreeis
Copy link
Contributor

CMake Tools 1.4.0 Beta is available on GitHub.
https://github.com/microsoft/vscode-cmake-tools/releases/tag/1.4.0-beta

Please try it out and let us know if you encounter any issues.

@OXINARF
Copy link
Author

OXINARF commented May 16, 2020

@bobbrow Sorry for the big delay, the "new world" started and I completely forgot about this. In the meanwhile, I've been able to make server mode work (it was SDK's fault), but the cmake.loggingLevel wasn't useful as it doesn't display the executed commands - I've tried all debug/trace/logging options and none would output it.

@andreeis @bobbrow The fix inserted by #1218 was to remove the setting, which is good, but doesn't really fix this issue because the warning (and setting communicationMode accordingly) only happens when useCMakeServer is set to true - this issue is exactly about the opposite case, when it is set to false.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature: settings fixed (release pending) fixed in pre-release and is pending official release
Projects
None yet
Development

No branches or pull requests

3 participants