Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-root workspaces don't provide per-folder browse configuration info #1073

Closed
sean-mcmanus opened this issue Feb 13, 2020 · 5 comments
Closed
Assignees
Labels
bug a bug in the product Feature: cpptools integration Feature: multiroot fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

With a multi-root workspace, provideBrowseConfiguration is only returning info on one workspace folder and canProvideBrowseConfigurationsPerFolder should return true...if it that's impossible it should return the browse data for all the workspace folders instead of one.

This isn't working for the existing cpptools or our pending 1.0 release that has a completely different multi-root implementation.

@sean-mcmanus
Copy link
Contributor Author

In cpptools.ts, CppConfigurationProvder._workspaceBrowseConfiguration data just gets overwritten by the 2nd workspace folder data.

@xisui-MSFT @andreeis Are any of you able to work on this? This is a high priority for our cpptools 1.0 release.

@sean-mcmanus
Copy link
Contributor Author

Looks like provideFolderBrowseConfiguration also needs to be implemented.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Feb 13, 2020

I figured out a potential hack/workaround via skipping the bogus browse configuration if none of the paths share the same workspace folder, which is usually the case when we're given browse config info for the wrong workspace folder. See microsoft/vscode-cpptools@33e25f6 .

@sean-mcmanus sean-mcmanus self-assigned this Mar 4, 2020
@bobbrow bobbrow added the fixed (release pending) fixed in pre-release and is pending official release label May 7, 2020
@andreeis
Copy link
Contributor

CMake Tools 1.4.0 Beta is available on GitHub.
https://github.com/microsoft/vscode-cmake-tools/releases/tag/1.4.0-beta

Please try it out and let us know if you encounter any issues.

@andreeis
Copy link
Contributor

This fix is available in CMake Tools #1.4.0 which has been released.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product Feature: cpptools integration Feature: multiroot fixed (release pending) fixed in pre-release and is pending official release IMPORTANT
Projects
None yet
Development

No branches or pull requests

3 participants