Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests as a single CTest invocation #3149

Closed
MathiasMagnus opened this issue Apr 29, 2023 · 3 comments
Closed

Run tests as a single CTest invocation #3149

MathiasMagnus opened this issue Apr 29, 2023 · 3 comments
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: ctest fixed (release pending) fixed in pre-release and is pending official release
Milestone

Comments

@MathiasMagnus
Copy link
Contributor

Brief Issue Summary

I wasn't too excited to hear that CMake Tools started biting into Test Explorer integration, because Frederic Bonnet's CMake Test Explorer is an otherwise stellar extension doing the same thing and he has already fixed a lot of the issues CMake Tools is just about to encounter.

One of these issues is CMake Tools (like Frederic's extension initially) wanted to outsmart CTest and launch tests using various CTest invocations. The problem with this is that it breaks a lot of CTest functionality around Resource Awarness, Resource Locks and Fixtures. This issue of mine on his repo details what the problem is, but the gist of it is that it is virtually impossible to run tests in any other way than a single ctest CLI invocation without breaking test execution.

I am aware that CMake Tools advertized that initially tests can't run in parallel, however I wanted to note that however CMake Tools wishes to move forward, it should probably be formulating a single CLI invocation based on user input. CTest does a whole bunch of test provisioning that is extremely hard (if not impossible) to re-implement from outside. @xisui-MSFT

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@benmcmorran benmcmorran added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: ctest labels May 2, 2023
@gcampbell-msft gcampbell-msft added this to the On Deck milestone Dec 11, 2023
@gcampbell-msft
Copy link
Collaborator

@MathiasMagnus FYI, I have a PR out now that allows users to disable the Test Explorer integration. So, I'd love for you to, once this change is released, test this out again!

@hippo91
Copy link
Contributor

hippo91 commented May 9, 2024

@gcampbell-msft i think this issue is solved by #3577. Am I wrong?

@gcampbell-msft
Copy link
Collaborator

@hippo91 You are correct. I'll mark this as fixed-pending-release. Thanks!

@gcampbell-msft gcampbell-msft added the fixed (release pending) fixed in pre-release and is pending official release label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: ctest fixed (release pending) fixed in pre-release and is pending official release
Projects
Status: Completed
Development

No branches or pull requests

4 participants