Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification that Configure Failed, Debug with CMake Debugger shows up when you override a Configure with a Build #3343

Closed
sinemakinci1 opened this issue Sep 14, 2023 · 12 comments
Assignees
Labels
bug a bug in the product Feature: build Feature: CMake Debugger Feature: configure fixed (release pending) fixed in pre-release and is pending official release
Projects
Milestone

Comments

@sinemakinci1
Copy link
Contributor

Brief Issue Summary

When a CMake Configure action is running, and you override with a Build action, I get an error that Configure Failed, Debug with CMake Debugger. Ideally, this would not surface to the user, since nothing "failed".

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@gcampbell-msft gcampbell-msft added this to Triage in 1.16 via automation Sep 15, 2023
@gcampbell-msft gcampbell-msft added this to the 1.16 milestone Sep 15, 2023
@cjdb
Copy link

cjdb commented Sep 16, 2023

There should also be a way to disable the pop-up for legitimate cases.

@gcampbell-msft
Copy link
Collaborator

@cjdb Thanks for the suggestion. Could you elaborate some on what you mean by "legitimate cases"? It'd be great to understand any and all cases where we should allow this.

@cjdb
Copy link

cjdb commented Sep 25, 2023

That would be whatever the reason the popup was designed for.

@hugsy
Copy link

hugsy commented Nov 12, 2023

There should also be a way to disable the pop-up for legitimate cases.

Agreed 💯, that pop-up is extremely annoying. There should be an option to disable it.

@teo-tsirpanis
Copy link

The same error pops when I cancel configuring (#3472).

@gcampbell-msft gcampbell-msft modified the milestones: 1.17, On Deck Nov 29, 2023
@gcampbell-msft gcampbell-msft moved this from Triage to To do in 1.17 Dec 4, 2023
@gcampbell-msft gcampbell-msft modified the milestones: On Deck, 1.17 Dec 12, 2023
@gcampbell-msft gcampbell-msft self-assigned this Dec 14, 2023
@gcampbell-msft gcampbell-msft added the fixed (release pending) fixed in pre-release and is pending official release label Jan 3, 2024
1.17 automation moved this from To do to Done Feb 13, 2024
@cjdb
Copy link

cjdb commented Feb 18, 2024

The "Do not show again" button doesn't appear to have any effect. I still get the pop-up even after pressing that button (I've run CMake twice in a row after pressing the button to see if a change in my environment is the culprit, and it is not).

@gcampbell-msft
Copy link
Collaborator

If you search for cmake.showConfigureWithDebuggerNotification in your settings, could you tell me what you see? I've just tested on the most recent pre-release whether this takes affect, and I've confirmed (for my repro) that it does take affect. I'm wondering if there is some settings issue that is happening?

Thanks.

@gcampbell-msft
Copy link
Collaborator

@cjdb Also, what operating system are you on?

@cjdb
Copy link

cjdb commented Feb 22, 2024

If you search for cmake.showConfigureWithDebuggerNotification in your settings, could you tell me what you see? I've just tested on the most recent pre-release whether this takes affect, and I've confirmed (for my repro) that it does take affect. I'm wondering if there is some settings issue that is happening?

That setting isn't present in my settings.json.

@cjdb Also, what operating system are you on?

Arch Linux. I've also run the following, which may be relevant too?

$ code --version
1.86.1
31c37ee8f63491495ac49e43b8544550fbae4533
x64

@cjdb
Copy link

cjdb commented Feb 22, 2024

Update: I see "cmake.showConfigureWithDebuggerNotification": false on my work machine, which runs macOS. Perhaps my Arch VS Code build is out-of-date.

@gcampbell-msft
Copy link
Collaborator

@cjdb It might not be in your settings.json yet, but if you search for it in the global settings UI, you should be able to find it.

Could you check there?

@cjdb
Copy link

cjdb commented Feb 25, 2024

Yep, it's there. Looks like the global settings UI is having difficulty writing to my settings.json, but I've been able to write to that manually, which seems to have solved my problem :)

My guess is that I've got a permissions issue or something, but that's out of scope for the bug.

Thank you for your assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product Feature: build Feature: CMake Debugger Feature: configure fixed (release pending) fixed in pre-release and is pending official release
Projects
Status: Completed
1.17
Done
Development

No branches or pull requests

6 participants