Fix3321 - Use empty to prevent destructure of undefined #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlavati
changed the title
|
@vlavati To be verbose, could you post screenshots or a gif in the description to confirm that this fixes the issue? Otherwise, this looks good to me. Please make a changelog entry and then we can approve. Thanks! |
|
Hi, @gcampbell-msft . It is updated. Could you review? Thanks in advance. |
gcampbell-msft
approved these changes
Oct 2, 2023
|
It is a known test issue that the Windows tests are failing. Merging this approved fixed without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #3321
The following changes are proposed:
The purpose of this change
This change fixes the bug.
The reproducing