Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension display language not right #3791

Open
xxxbrian opened this issue May 25, 2024 · 2 comments
Open

Extension display language not right #3791

xxxbrian opened this issue May 25, 2024 · 2 comments
Labels
more info needed More info is needed from the community for us to properly triage and investigate.
Milestone

Comments

@xxxbrian
Copy link

Brief Issue Summary

The same issue as #3691 , the cmake extension displays the wrong language.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@xxxbrian
Copy link
Author

Did some digging, this is due to Code

export function getLocaleId(): string {
    if (typeof (process.env.VSCODE_NLS_CONFIG) === "string") {
        const vscodeNlsConfigJson: any = JSON.parse(process.env.VSCODE_NLS_CONFIG);
        if (typeof (vscodeNlsConfigJson.locale) === "string") {
            return vscodeNlsConfigJson.locale;
        }
    }
    return "en";
}

process.env.VSCODE_NLS_CONFIG is used to retrieve VSCode NLS. This is an incorrect usage and it seems that this environment variable has been deprecated (as the value it obtains is completely wrong).

@gcampbell-msft
Copy link
Collaborator

@xxxbrian Thanks for the issue. I took a look at the PR, and based on the API reading I just did, that seems like it will work for that method. However, that almost certainly won't fix the overall issue because we only use that method for the presentation of the pinned commands.

Have you tried the workaround mentioned in this bug? #3691

Could you confirm whether the above is the case?

@Yingzi1234 Yingzi1234 added more info needed More info is needed from the community for us to properly triage and investigate. and removed triage labels May 30, 2024
@gcampbell-msft gcampbell-msft added this to the Backlog milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info needed More info is needed from the community for us to properly triage and investigate.
Projects
Status: Blocked
Development

No branches or pull requests

3 participants