Duplicated launch targets

[Zingam]

Maybe this is fixed already but I am unable to find such issue.
Whenever I need to select a launch target I see duplicated entries:

Maybe whenever there is just one target in the project it should be selected by default and no select popup menu should be displayed.

[Zingam]

I can still see the duplicated entries in 1.2.1.

[KoeMai]

I tried to reconstruct the dublicate entries. But I don´t see it. Are this duplicate launch configurations or execution targets? When is the dialog shown? How does the launch configuration looks like? And which tool versions are used?

[Zingam]

When I click on "Debug" on the status bar. I have been observing this for a while now in a project I have.
I tried to quickly debug it but couldn't get any idea what was going on. The above screenshot was made on Ubuntu. Here a a couple of screenshot on Windows.

I may need investigate some more.

Here I clicked: [all] "Set the active target to build" on the status bar.

Here I clicked: [Debug] "Select target to launch" on the status bar.

[KoeMai]

The project contains to executable targets from different projects (see cmake: project outline).
May be it is helps to add the project into the target description.

[Zingam]

@KoeMai This is puzzling. I have just one add_executable in the source. Also that other library ThirdParty/glad also appears twice.
I use Visual Studio 2019 mostly and I don't observe that kind of duplicated executable targets there.

Edit: The library glad appears three times in the outline actually.

[Zingam]

These are the debug targets as seen in VS2019 and exactly as expected:

[Zingam]

The duplication of targets in the outline happens because I have multiple project commands in my CMakeLists.txt-s. When I removed all project commands but the one in the root CMakeLists.txt the Project outline started to look good.

The structure was:

• project 1 in the root CMakeLists.txt adds project 2's and project 3's CMakeLists.txt
  • project 2 in sub-CMakeLists.txt(contains a library target) addsproject4'sCMakeLists.txt`
  • project 3 in sub-CMakeLists.txt (contains an executable target)
  • project 4 in sub-CMakeLists.txt (contains a library target)

I don't think that my CMakeLists.txt are wrong. I would blame the way the tree is constructed as the targets are included multiple times in the tree, probably once for each add_subdirectory./project command CMakeLists.txt.
I'll try to recreate this with a simpler project.

[Zingam]

The CMake server returns a list of projects:

• https://cmake.org/cmake/help/v3.16/manual/cmake-server.7.html#type-codemodel
• https://cmake.org/cmake/help/v3.16/manual/cmake-file-api.7.html#object-kind-codemodel

And the extension just puts them into the Outliner:

updateCodeModel(model: cms.CodeModelContent|null, exCtx: {launchTargetName: string|null, defaultTargetName: string}) {
    if (!model || model.configurations.length < 1) {
      return;
    }
    this._codeModel = model;
    const config = model.configurations[0];
    const updates: BaseNode[] = [];
    const new_children: BaseNode[] = [];
    for (const pr of config.projects) {
      const item = new ProjectNode(pr.name);
      item.update(pr, {...exCtx, nodesToUpdate: updates});
      new_children.push(item);
    }
    this._children = new_children;

    this._changeEvent.fire(null);
    for (const node of updates) {
      this._changeEvent.fire(node);
    }
  }

The CMake server returns all sub-branches of the project tree as a list of projects.
I cannot see a reason why the extension should iterate over all projects (calls to the command project()) and their sub-projects (subsequent calls to project()). I think it should just use the top-level project (or too-level projects when the extension starts supporting multiple top-level projects), which is the project in the root CMakeLists.txt file.

• https://cmake.org/cmake/help/v3.16/command/project.html

The top-level CMakeLists.txt file for a project must contain a literal, direct call to the project() command;

[Zingam]

A simple sample project:

CMakeMultiProject.zip

[bobbrow]

Thanks for the example. I created a PR for this.

[bobbrow]

Ha, I spoke too soon. I only fixed the build selector. I need to fix the launch one too.