Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between repo and official product icon reference #44

Closed
mike-lischke opened this issue Feb 15, 2021 · 4 comments
Closed
Assignees
Labels

Comments

@mike-lischke
Copy link

I'm not sure if this a documentation problem, a real bug or something I misunderstand, but here we go.

When I compare the list of icons in this repository, which is apparently what is used by vscode, I would expect that it corresponds to the product icon reference, which however is not the case. Fore example I don't see any of the find-* icons mentioned in the reference.

And here's a side question, but also related: does the monaco-editor use exactly the same icons or just a subset? For example, I get no output for codicon-output, even though this icon is both, in this repo and mentioned in the icon reference.

@miguelsolorio
Copy link
Contributor

So the list on the product icon reference page has a "codicon id" column, this is the id that is used in this repo:

image

So the find-* icons, the second column is the id:

image

Does that help? And for the monaco editor, they are using the same icons however I'm not sure how often the editor gets updated with the latest.

@mike-lischke
Copy link
Author

mike-lischke commented Feb 17, 2021

OK, thanks, that explains the name differences. But the other question still stands: does monaco-editor use the same set of codicons? If so, why is nothing shown for the output codicon? Looking in the HTML code I see it doesn't add the ::before pseudo node for that, which it does for other codicons.

Since monaco-editor is created from vscode code, I hope this is a valid question here.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Feb 17, 2021

Yes, codicons are part of the monaco editor since you see them in the suggest widget. You might want to post in https://github.com/Microsoft/monaco-editor and cc me about it there and show an example of how you're referencing the icons.

See first item in the list:
image

@miguelsolorio
Copy link
Contributor

Will close this issue as I believe your question was answered, please free to create a new issue here or in the monaco-editor repo for any new questions/issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants