Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function parameters tooltip goes away once you start adding parameters. #1165

Closed
rdlaner opened this issue Oct 24, 2017 · 6 comments
Closed
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@rdlaner
Copy link

rdlaner commented Oct 24, 2017

Windows 10
VS Code Insiders 1.18.0
C/C++ extension version: 0.14.0

When I start a function call, the extension gives a tooltip for completing the function parameters:
image

However, as soon as the first parameter is added, the tool tip goes away. Is there any way/hot-key to invoke the tooltip again so that I can complete the function invocation? Ideally, it wouldn't go away at all.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Oct 24, 2017

@rdlaner Yeah, the parameter hint isn't supposed to go away until all the parameters are added (maybe the template is messing it up). You can try to use Ctrl+Shift+Space after the starting ( to reinvoke the signature help. I'm not able to repro this bug, so if you can provide a repro that would help to fix it (a normal template method didn't repro the issue for me). We do some special case parsing, so it's probably some special character in your argument list that is messing it up.

@sean-mcmanus sean-mcmanus added bug more info needed The issue report is not actionable in its current state labels Oct 24, 2017
@rdlaner
Copy link
Author

rdlaner commented Oct 25, 2017

@sean-mcmanus I did a few more tests and found that the parameter hint sticks around if I am adding POD types, but if I need to dereference a pointer or access a member variable or use the scope operator the hint goes away after adding one of those types of parameters.

Does the hint stick around for you if you try any of those parameter types?

@sean-mcmanus
Copy link
Collaborator

Yes, I'm able to repro this now -- the signature help is disappearing whenever a ":" or ">" is used. This might be a VS Code bug, but we'll need to investigate more to be sure.

@sean-mcmanus sean-mcmanus added Language Service and removed more info needed The issue report is not actionable in its current state labels Oct 25, 2017
@sean-mcmanus
Copy link
Collaborator

Yes, I've verified that these are bugs with our extension code (I believe regressions starting in 0.13.0 when we made changes to the signature help implementation). Thanks for reporting this issue. The "identifier:" bug only repros with the "Default" IntelliSense engine, but the other bug also repros with the Tag Parser. We should be able to fix this.

@rdlaner
Copy link
Author

rdlaner commented Oct 26, 2017

Great, thanks @sean-mcmanus !

@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 13, 2017
@bobbrow
Copy link
Member

bobbrow commented Nov 28, 2017

This should be fixed with version 0.14.3

@bobbrow bobbrow closed this as completed Nov 28, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

3 participants