Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Extract to function' is not available due to error 'The selected text cannot span different functions' in certain cases #11727

Open
sean-mcmanus opened this issue Nov 22, 2023 · 0 comments
Assignees
Labels
bug Feature: Extract to function Extract to function (free function or member function) Language Service
Projects
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Nov 22, 2023

Repros after selecting the "return 0;" and using Ctrl+Shift+R Ctrl+E.

int func()
{

    return 0;
}

Doesn't repro after 2 new lines are added to the top of the file (the markdown isn't rendering the blank lines correctly).

int func()
{

    return 0;
}
image

I'm not sure how widespread the issue is.

@sean-mcmanus sean-mcmanus added bug Language Service Feature: Extract to function Extract to function (free function or member function) labels Nov 22, 2023
@sean-mcmanus sean-mcmanus added this to the 1.19 milestone Nov 22, 2023
@sean-mcmanus sean-mcmanus added this to Triage in 1.19 via automation Nov 22, 2023
@sean-mcmanus sean-mcmanus self-assigned this Nov 22, 2023
@sean-mcmanus sean-mcmanus moved this from Triage to To do in 1.19 Nov 22, 2023
@sean-mcmanus sean-mcmanus changed the title 'Extract to function' fails with 'The selected text cannot span different functions' in certain cases 'Extract to function' is not available due to error 'The selected text cannot span different functions' in certain cases Nov 22, 2023
@sean-mcmanus sean-mcmanus moved this from To do to Triage in 1.19 Jan 22, 2024
@bobbrow bobbrow added this to Triage in 1.20 via automation Jan 30, 2024
@bobbrow bobbrow removed this from Triage in 1.19 Jan 30, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.19, 1.20 Feb 23, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.20, 1.21 Apr 22, 2024
@sean-mcmanus sean-mcmanus removed this from Triage in 1.20 Apr 22, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.21 via automation Apr 22, 2024
@bobbrow bobbrow modified the milestones: 1.21, On Deck Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Extract to function Extract to function (free function or member function) Language Service
Projects
Status: Triage
1.21
Triage
Development

No branches or pull requests

2 participants