Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #include "file.h" is incorrectly suggested instead of <file.h> for subDir/file.h #12002

Open
sean-mcmanus opened this issue Feb 22, 2024 · 0 comments
Assignees
Labels
bug Feature: Add '#include' Add '#include' code action on undefined symbols Language Service Visual Studio Inherited from Visual Studio
Projects
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Feb 22, 2024

See the screenshot -- test2 is on the includePath and the current file is at the root, so it should be suggesting <file.h> since file.h is not in the same folder as the source file.

image

The issue in inherited from Visual Studio (shared code).

It was found after adding a test case for #11989

@sean-mcmanus sean-mcmanus added bug Language Service Visual Studio Inherited from Visual Studio Feature: Add '#include' Add '#include' code action on undefined symbols labels Feb 22, 2024
@sean-mcmanus sean-mcmanus self-assigned this Feb 22, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.20 via automation Feb 23, 2024
@sean-mcmanus sean-mcmanus added this to the 1.20 milestone Feb 23, 2024
@sean-mcmanus sean-mcmanus moved this from Triage to In progress in 1.20 Feb 23, 2024
@bobbrow bobbrow moved this from In progress to To do in 1.20 Mar 12, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.21 via automation Apr 22, 2024
@sean-mcmanus sean-mcmanus removed this from To do in 1.20 Apr 22, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.20, 1.21 Apr 22, 2024
@bobbrow bobbrow assigned browntarik and unassigned sean-mcmanus May 14, 2024
@bobbrow bobbrow modified the milestones: 1.21, On Deck Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Add '#include' Add '#include' code action on undefined symbols Language Service Visual Studio Inherited from Visual Studio
Projects
Status: Triage
1.21
Triage
Development

No branches or pull requests

3 participants