Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C_Cpp.inlayHints settings don't take effect until IntelliSense is updated #12013

Closed
sean-mcmanus opened this issue Feb 24, 2024 · 1 comment · Fixed by #12014
Closed

C_Cpp.inlayHints settings don't take effect until IntelliSense is updated #12013

sean-mcmanus opened this issue Feb 24, 2024 · 1 comment · Fixed by #12014
Assignees
@sean-mcmanus
Labels
bug Feature: Inlay Hint An issue related to inlay hints for declarations and parameters. fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
1.19
Milestone
1.19.5

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Feb 24, 2024 •
edited
Loading 

"C_Cpp.inlayHints.parameterNames.enabled": true, // changing this doesn't

"editor.inlayHints.enabled": "on" // changing this works

"editor.parameterHints.enabled" // changing this doesn't work

These appear to be regressions from 1.18 from progressive IntelliSense updating.

I hit this while investigating the test failure #12008 .
@sean-mcmanus sean-mcmanus added bug Language Service regression A bug that didn't exist in a previous release Feature: Inlay Hint An issue related to inlay hints for declarations and parameters. labels Feb 24, 2024
@sean-mcmanus sean-mcmanus changed the title Inlay hint settings don't take effect until the IntelliSense client is restarted C_Cpp.inlayHint settings don't take effect until the IntelliSense client is restarted Feb 24, 2024
@sean-mcmanus sean-mcmanus changed the title C_Cpp.inlayHint settings don't take effect until the IntelliSense client is restarted C_Cpp.inlayHints settings don't take effect until the IntelliSense client is restarted Feb 24, 2024
@sean-mcmanus sean-mcmanus self-assigned this Feb 24, 2024
@sean-mcmanus sean-mcmanus added this to the 1.20.0 milestone Feb 24, 2024
@sean-mcmanus sean-mcmanus added this to Triage in 1.20 via automation Feb 24, 2024
@sean-mcmanus sean-mcmanus moved this from Triage to In progress in 1.20 Feb 24, 2024
@sean-mcmanus sean-mcmanus changed the title C_Cpp.inlayHints settings don't take effect until the IntelliSense client is restarted C_Cpp.inlayHints settings don't take effect until IntelliSense is updated Feb 24, 2024
@sean-mcmanus sean-mcmanus moved this from In progress to Pull Request in 1.20 Feb 24, 2024
@sean-mcmanus
Copy link
Collaborator Author

sean-mcmanus commented Feb 24, 2024 •
edited
Loading

Well, I fixed it "editor.inlayHints.enabled": "on" // changing this works changes not working if enhancedColorization was disabled, and I fixed it so the C_Cpp.inlayHints refreshes.

@sean-mcmanus sean-mcmanus mentioned this issue Feb 24, 2024
Merged
@bobbrow bobbrow added this to In progress in 1.19 Feb 27, 2024
@bobbrow bobbrow removed this from Pull Request in 1.20 Feb 27, 2024
@bobbrow bobbrow modified the milestones: 1.20.0, 1.19.5 Feb 27, 2024
@bobbrow bobbrow linked a pull request Feb 27, 2024 that will close this issue
Fix inlay hint tests. And reapply inlay hint settings if they're changed #12014
Merged
1.19 automation moved this from In progress to Done Feb 27, 2024
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 27, 2024
This was referenced Mar 5, 2024
Closed
Closed
This was referenced Mar 13, 2024
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug Feature: Inlay Hint An issue related to inlay hints for declarations and parameters. fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
No open projects
1.19
Done
Milestone
1.19.5
Development

Successfully merging a pull request may close this issue.

Fix inlay hint tests. And reapply inlay hint settings if they're changed microsoft/vscode-cpptools
2 participants
@bobbrow @sean-mcmanus