Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to Definition on a #include path doesn't use the IntelliSense info #2564

Closed
sean-mcmanus opened this issue Sep 26, 2018 · 5 comments
Closed

Go to Definition on a #include path doesn't use the IntelliSense info #2564

sean-mcmanus opened this issue Sep 26, 2018 · 5 comments
Labels
Feature: Go to Definition An issue related to Go to Definition/Declaration. Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
0.28.0
Milestone
0.28.0

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Sep 26, 2018 •
edited
Loading

It should go to the definition that is actually being used by the current translation unit (i.e. not showing all the files that match the include path).
@sean-mcmanus sean-mcmanus added this to the October 2018 milestone Sep 26, 2018
@sean-mcmanus sean-mcmanus self-assigned this Sep 28, 2018
@sean-mcmanus sean-mcmanus mentioned this issue Sep 29, 2018
Closed
@sean-mcmanus sean-mcmanus modified the milestones: October 2018, On Deck Oct 4, 2018
@sean-mcmanus sean-mcmanus removed their assignment Oct 4, 2018
@sean-mcmanus sean-mcmanus mentioned this issue Nov 14, 2018
Open
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, December 2018 Nov 30, 2018
@sean-mcmanus sean-mcmanus self-assigned this Nov 30, 2018
@sean-mcmanus
Copy link
Collaborator Author

sean-mcmanus commented Nov 30, 2018 •
edited
Loading

It looks like this will be fixed via invoking the new #include completion at the end of the #include.

@sean-mcmanus sean-mcmanus mentioned this issue Dec 31, 2018
Closed
@sean-mcmanus sean-mcmanus removed their assignment Feb 6, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Feb 9, 2019
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Mar 5, 2019
Closed
@sean-mcmanus sean-mcmanus modified the milestones: March 2019, April 2019 Mar 11, 2019
@sean-mcmanus sean-mcmanus added the Feature: Go to Definition An issue related to Go to Definition/Declaration. label Apr 17, 2019
@sean-mcmanus sean-mcmanus modified the milestones: April 2019, On Deck May 8, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Jul 26, 2019
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Sep 3, 2019
Closed
@bobbrow bobbrow modified the milestones: On Deck, Post-v1 Sep 27, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Oct 10, 2019
Closed
@bobbrow bobbrow mentioned this issue Oct 18, 2019
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Nov 26, 2019
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Dec 13, 2019
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Mar 19, 2020
Closed
This was referenced Mar 22, 2020
Closed
Open
@sean-mcmanus
Copy link
Collaborator Author

@bobbrow Users are frequently hitting this . It makes them think their project isn't configured correctly when it is. See all the linked issues.

@bobbrow
Copy link
Member

bobbrow commented Mar 28, 2020

We should move this into the next release then.

@bobbrow bobbrow modified the milestones: Post-v1, 1.0 Mar 28, 2020
@bobbrow bobbrow added this to To do in 0.28.0 via automation Mar 28, 2020
@bobbrow bobbrow mentioned this issue Mar 28, 2020
Closed
@bobbrow bobbrow moved this from To do to On Deck in 0.28.0 Apr 14, 2020
@HampusAdolfsson HampusAdolfsson mentioned this issue Apr 15, 2020
Open
@sean-mcmanus sean-mcmanus moved this from On Deck to In progress in 0.28.0 Apr 15, 2020
@bobbrow bobbrow moved this from In progress to On Deck in 0.28.0 Apr 16, 2020
@sean-mcmanus sean-mcmanus moved this from On Deck to Done in 0.28.0 Apr 17, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 17, 2020
@sean-mcmanus sean-mcmanus removed their assignment Apr 17, 2020
@ghuser404
Copy link

This works, but may be too slow at times. Sometimes it takes 30 seconds to jump into correct header. Is anything being done about IntelliSense performance?

@sean-mcmanus sean-mcmanus mentioned this issue Apr 30, 2020
Open
@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature: Go to Definition An issue related to Go to Definition/Declaration. Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
No open projects
0.28.0
  
Done
Milestone
0.28.0
Development

No branches or pull requests
4 participants
@bobbrow @elahehrashedi @sean-mcmanus @ghuser404