Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find All References fails for variables on the last line of a file if there's no newline #4150

Closed
sean-mcmanus opened this issue Aug 27, 2019 · 0 comments
Labels
bug Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

Do find all references on "abc1" in the code below:

int abc1 = 0;
int abc2 = abc1;

Bug: In the "C/C++ References" section it incorrectly gives

[Cannot confirm reference] test.cpp:1:20 int abc1 = 0;
int abc2 = abc1;

This seems like a corner case that no users would likely hit in normal code -- however, it's possible the root bug could be causing other issues so it might be worth investigating. It is worked around by adding a new line to the end of the file.

@sean-mcmanus sean-mcmanus added bug Language Service more votes needed Issues that have been postponed until more community members upvote it Feature: Find All References Find All References, Peek References, Rename labels Aug 27, 2019
@michelleangela michelleangela added this to the Triage milestone Aug 28, 2019
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. quick fix labels Oct 3, 2019
@sean-mcmanus sean-mcmanus modified the milestones: Triage, 0.26.0 Oct 3, 2019
@sean-mcmanus sean-mcmanus removed the more votes needed Issues that have been postponed until more community members upvote it label Oct 3, 2019
@sean-mcmanus sean-mcmanus reopened this Oct 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

2 participants