Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C/C++: Log Diagnostics shows incorrect defines when compile_commands.json is used #4270

Closed
sean-mcmanus opened this issue Sep 18, 2019 · 1 comment
Closed

C/C++: Log Diagnostics shows incorrect defines when compile_commands.json is used #4270

sean-mcmanus opened this issue Sep 18, 2019 · 1 comment
Assignees
@Colengms
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
0.26.2 Milestone 0.27.0 Milestone
Milestone
0.26.3

Comments

@sean-mcmanus
Copy link
Collaborator

It shows the c_cpp_properties.json defines.

Originally reported at #4269 .
@sean-mcmanus sean-mcmanus added this to the On Deck milestone Sep 18, 2019
@sean-mcmanus sean-mcmanus changed the title C/C++: Log Diagnostics shows incorrect results when compile_commands.json is used C/C++: Log Diagnostics shows incorrect defines when compile_commands.json is used Sep 18, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Sep 18, 2019
Closed
@bobbrow bobbrow modified the milestones: On Deck, 1.0.0 Sep 27, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Nov 19, 2019
Closed
@sean-mcmanus
Copy link
Collaborator Author

Also repros with custom config providers.

@bobbrow bobbrow added this to To Do in 0.26.2 Milestone Nov 26, 2019
@bobbrow bobbrow moved this from To Do to On Deck in 0.26.2 Milestone Nov 27, 2019
@Colengms Colengms moved this from On Deck to In Progress in 0.26.2 Milestone Dec 3, 2019
@Colengms Colengms self-assigned this Dec 3, 2019
@bobbrow bobbrow moved this from In Progress to Pull Requests in 0.26.2 Milestone Dec 5, 2019
@bobbrow bobbrow moved this from Pull Requests to Done in 0.26.2 Milestone Dec 6, 2019
@bobbrow bobbrow added this to Done in 0.27.0 Milestone Dec 6, 2019
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 6, 2019
@sean-mcmanus sean-mcmanus modified the milestones: 1.0.0, 0.26.3 Jan 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
No open projects
0.26.2 Milestone
  
Done
0.27.0 Milestone
  
Done
Milestone
0.26.3
Development

No branches or pull requests
3 participants
@bobbrow @sean-mcmanus @Colengms