Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish issues for v.1.0 #4364

Closed
4 tasks done
bobbrow opened this issue Oct 1, 2019 · 6 comments
Closed
4 tasks done

Fit and Finish issues for v.1.0 #4364

bobbrow opened this issue Oct 1, 2019 · 6 comments
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@bobbrow
Copy link
Member

bobbrow commented Oct 1, 2019

  • Rename language server binaries (and update build pipelines + resource.in on Windows)
    • cpptools.exe (win32)
    • cpptools (linux/mac)
    • cpptools-srv.exe (win32)
    • cpptools-srv (linux/mac)
  • Update the "FileDescription" of the language service binary (for Windows)
  • Rename settings with non-conforming names (e.g. clang_format)
    • Consider rename of C_Cpp -> cpptools
  • Remove unneeded node_modules from vsix since they are webpacked.
@bobbrow bobbrow added this to the 1.0.0 milestone Oct 1, 2019
@bobbrow bobbrow added this to On Deck in 0.26.2 Milestone Nov 26, 2019
@bobbrow bobbrow added this to To do in 0.27.0 Milestone Dec 6, 2019
@bobbrow bobbrow removed this from On Deck in 0.26.2 Milestone Dec 6, 2019
@bobbrow bobbrow moved this from To do to On Deck in 0.27.0 Milestone Dec 6, 2019
@bobbrow bobbrow moved this from On Deck to In progress in 0.27.0 Milestone Jan 24, 2020
@Colengms Colengms moved this from In progress to Done in 0.27.0 Milestone Jan 30, 2020
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 4, 2020
@kjemeyer
Copy link

Hi Bob,

I am using Fedora 30 and it looks like this change is causing issues for me.

"Unable to start the C/C++ language server. IntelliSense features will be disabled. Error: Missing binary at /home/kmeyer/.vscode/extensions/ms-vscode.cpptools-0.27.0/bin/cpptools"

When I go to that directory there is no cpptools file.
image

Is it possible that linux missed the update?

The extension version is .27 and the vscode version is 1.43.2. In case there was a stale config, I deleted my .vscode directory, .config/Code directory and reinstalled the vscode binary.

Let me know what you think.

Thanks,

Best.

Kevin

@sean-mcmanus
Copy link
Collaborator

@kjemeyer Is your OS 32-bit or 64-bit? You used the normal online install path and not the manually installed vsix, right?

@kjemeyer
Copy link

My OS is 64 bit. I was able to resolve the issue by installing using vsix and giving cpptools and cpptools-srv executable permissions

@kjemeyer
Copy link

(chmod +x)

@sean-mcmanus
Copy link
Collaborator

@kjemeyer It's possible you encountered some random networking issue that caused a failure with our online download. Using the vsix should be a workaround, but it should not normally require changing executable permissions since our vsix is supposed to do that already (if not, that would be another bug). Normally, the online vsix should give

Updating C/C++ dependencies...

Downloading package 'C/C++ language components (Linux / x86_64)' (9321 KB)  Done!
Downloading package 'ClangFormat (Linux / x86_64)' (894 KB)  Done!
Downloading package 'Mono Framework Assemblies' (5368 KB)  Done!
Downloading package 'Mono Runtime (Linux / x86_64)' (1862 KB)  Done!

Installing package 'C/C++ language components (Linux / x86_64)'
Installing package 'ClangFormat (Linux / x86_64)'
Installing package 'Mono Framework Assemblies'
Installing package 'Mono Runtime (Linux / x86_64)'

Finished installing dependencies

from using the download from https://go.microsoft.com/fwlink/?linkid=2125055 .

@kjemeyer
Copy link

Appreciate the quick response :) I will let you know if I encounter issues when I upgrade the extension next. Btw vscode is great!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
No open projects
Development

No branches or pull requests

3 participants