Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic colorization doesn't update after deleting settings.json with colorization changes #5023

Closed
sean-mcmanus opened this issue Feb 27, 2020 · 3 comments
Assignees
Labels
bug Feature: Colorization Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Feb 27, 2020

  1. Put
        "textMateRules": [
            {
                "scope": "entity.name.type",
                "settings": {
                    "foreground": "#FF0000",
                    "fontStyle": "italic bold underline"
                }
            }
        ]
    }

in settings.json.
2. See the colors update with code

void myfunction(int var1, std::string var2, std::string var3)
{
}
  1. Delete settings.json.

Bug: The colors don't update. Reload window fixes it. The new colorization implementation might fix this: #4992

@Colengms
Copy link
Collaborator

Colengms commented Mar 9, 2020

This looks like a VS Code issue. Editing settings.json, within VS Code or externally, results in the expected onDidChangeConfiguration notification. However, deleting the file, or copying the file to the .vscode directory, does not appear to trigger a notification.

Curiously, it looks like we get 2 invocations of file watcher events in .vscode, but not in other directories. (This also appears to be a VS Code issue).

@Colengms
Copy link
Collaborator

Colengms commented Mar 9, 2020

I've opened the following issue against VS Code: microsoft/vscode#92288

@Colengms Colengms modified the milestones: 0.27.0, Tracking Mar 9, 2020
@Colengms Colengms removed this from In progress in 0.27.0 Milestone Mar 9, 2020
@Colengms Colengms added the Visual Studio Code Caused by (or depends on changes from) VS Code label Mar 9, 2020
@Colengms
Copy link
Collaborator

Closing this as the linked bug is now closed (fixed). Though, the issue will persist until a version of VS Code containing the fix is shipped.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Colorization Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Projects
None yet
Development

No branches or pull requests

3 participants