Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage compiler system defines to determine types and sizes for IntelliSense #7355

Open
Colengms opened this issue Apr 13, 2021 · 0 comments
Labels
Feature Request internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Milestone

Comments

@Colengms
Copy link
Collaborator

Colengms commented Apr 13, 2021

Various type and sizes are essentially hard-coded per IntelliSense mode. Some are passed in based on a static file (such as __SIZE_TYPE__ and __PTRDIFF_TYPE in linux.gcc.x64.json). Some are hard-coded in the IntelliSense parser, based on the compiler and architecture (IntelliSense mode).

gcc/clang compilers will output types and sizes when queried, such as:

c:\msys64\mingw64\bin>gcc.exe -x c++ -E -dM nul | findstr /i SIZEOF
#define __SIZEOF_FLOAT80__ 16
#define __SIZEOF_LONG__ 4
#define __SIZEOF_LONG_DOUBLE__ 16
#define __SIZEOF_FLOAT__ 4
#define __SIZEOF_SIZE_T__ 8
#define __SIZEOF_WINT_T__ 2
#define __SIZEOF_POINTER__ 8
#define __SIZEOF_PTRDIFF_T__ 8
#define __SIZEOF_INT__ 4
#define __SIZEOF_FLOAT128__ 16
#define __SIZEOF_SHORT__ 2
#define __SIZEOF_INT128__ 16
#define __SIZEOF_WCHAR_T__ 2
#define __SIZEOF_DOUBLE__ 8
#define __SIZEOF_LONG_LONG__ 8

c:\msys64\mingw64\bin>gcc.exe -x c++ -E -dM nul | findstr /i long
#define __UINTMAX_TYPE__ long long unsigned int
#define __SIZEOF_LONG__ 4
#define __SIZEOF_LONG_DOUBLE__ 16
#define __LONG_LONG_MAX__ 0x7fffffffffffffffLL
#define __LONG_LONG_WIDTH__ 64
#define __INT_FAST64_TYPE__ long long int
#define __SIZE_TYPE__ long long unsigned int
#define __UINT_LEAST64_TYPE__ long long unsigned int
#define __LONG_MAX__ 0x7fffffffL
#define __INT_LEAST64_TYPE__ long long int
#define __GCC_ATOMIC_LONG_LOCK_FREE 2
#define __INTPTR_TYPE__ long long int
#define __UINT_FAST64_TYPE__ long long unsigned int
#define __INT64_TYPE__ long long int
#define __UINT64_TYPE__ long long unsigned int
#define __LONG_WIDTH__ 32
#define __INTMAX_TYPE__ long long int
#define __PTRDIFF_TYPE__ long long int
#define __UINTPTR_TYPE__ long long unsigned int
#define __SIZEOF_LONG_LONG__ 8
#define __GCC_ATOMIC_LLONG_LOCK_FREE 2

It's possible that different versions or flavors of the same compiler will output different values for these, even for the same architecture.

For example, both MinGW x64 and cygwin x64 are associated with the windows-gcc-x64 IntelliSense mode, but use different sizes for long.

D:\cygwin64\bin>gcc.exe -x c++ -E -dM /dev/null | findstr /i x86
#define __x86_64 1

D:\cygwin64\bin>gcc.exe -x c++ -E -dM /dev/null | findstr /i SIZEOF_LONG
#define __SIZEOF_LONG__ 8


c:\msys64\mingw64\bin>gcc.exe -x c++ -E -dM nul | findstr /i x86
#define __x86_64 1

c:\msys64\mingw64\bin>gcc.exe -x c++ -E -dM nul | findstr /i SIZEOF_LONG
#define __SIZEOF_LONG__ 4

Some gcc ports to Windows follow Windows conventions for types and sizes, and some use Linux conventions.

To improve compatibility between different versions and flavors of gcc compilers, we could use the queried system defines from the compiler to correct types and sizes.

@Colengms Colengms self-assigned this Apr 13, 2021
@Colengms Colengms changed the title Leverage compiler system defines to determine type and sizes for IntelliSense Leverage compiler system defines to determine types and sizes for IntelliSense Apr 13, 2021
@bobbrow bobbrow added this to the Triage milestone Apr 20, 2021
@Colengms Colengms added the internal Used to opt-out an issue from having GitHub actions applied to it label May 24, 2021
@Colengms Colengms modified the milestones: Triage, Backlog May 24, 2021
@bobbrow bobbrow modified the milestones: Backlog, Triage Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Projects
None yet
Development

No branches or pull requests

2 participants