Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message if the wrong platform-specific VSIX is installed #8908

Closed
Colengms opened this issue Feb 23, 2022 · 0 comments
Closed
Assignees
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects

Comments

@Colengms
Copy link
Collaborator

Prior to switching to platform-specific VSIX's via the marketplace, we would display an error message if we detected that the wrong platform binaries were installed (if the user had manually downloaded and installed the wrong platform VSIX). This error message should be added back in. There is still the potential to download the wrong platform-specific VSIX from the marketplace web site. There is also an issue in which VS Code may sometimes install the wrong VSIX: microsoft/vscode#141696

There is a TargetPlatform field written to the .vsixmanifest file at the root of the extension directory (when installed from a VSIX), that could be used for this check.

@Colengms Colengms added this to the 1.9 milestone Feb 23, 2022
@Colengms Colengms self-assigned this Feb 23, 2022
@Colengms Colengms added this to Triage in 1.9 via automation Feb 23, 2022
@Colengms Colengms moved this from Triage to In progress in 1.9 Feb 23, 2022
@Colengms Colengms moved this from In progress to Done in 1.9 Feb 23, 2022
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 23, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.9, 1.9.1 (insiders2) Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
No open projects
1.9
Done
Development

No branches or pull requests

2 participants