Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Properly document the Dockerfile requirements for the scripts #563

Closed
felipecrs opened this issue Sep 17, 2020 · 3 comments · Fixed by #569
Closed

Properly document the Dockerfile requirements for the scripts #563

felipecrs opened this issue Sep 17, 2020 · 3 comments · Fixed by #569
Labels

Comments

@felipecrs
Copy link
Contributor

felipecrs commented Sep 17, 2020

For example, node-debian.sh seems to require:

ARG NODE_VERSION="lts/*"
ENV NVM_DIR=/usr/local/share/nvm
ENV NVM_SYMLINK_CURRENT=true \
  PATH=${NVM_DIR}/current/bin:${PATH}

In order to work properly.

At least until we have microsoft/vscode-remote-release#3593, otherwise the scripts would take care of it by themselves.

@Chuxel
Copy link
Member

Chuxel commented Sep 17, 2020

@felipecrs Yep, agreed - Had this on the list here: #560. Can reuse this as the specific item for docs.

@Chuxel
Copy link
Member

Chuxel commented Sep 21, 2020

This is complete. Scripts will also reference the location of the doc for the script.

@felipecrs
Copy link
Contributor Author

The new docs are very nice. It's very clear now how to use those scripts. :-D

Thank you @Chuxel!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants