Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

[upstream] Cannot access noVNC from the web using Codespaces #854

Closed
sarisia opened this issue May 6, 2021 · 5 comments
Closed

[upstream] Cannot access noVNC from the web using Codespaces #854

sarisia opened this issue May 6, 2021 · 5 comments
Labels
bug Issue identified by VS Code Team member as probable bug script-library upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@sarisia
Copy link
Contributor

sarisia commented May 6, 2021

script-library/docs/desktop-lite.md has a guide for running noVNC in devcontainer, but it won't work due to the
lack of a step.

In Usage section, before accessing the published port in step 4, we need to "Right click the port -> Make Public" that port
or we'll get HTTP 308 for wss:// access and cannot establish WebSocket connection:

  1. Once you've started the container / codespace, you'll be able to use a browser on port 6080 from anywhere or connect a VNC viewer to port 5901 when accessing the codespace from VS Code.

image

It's better to have this step noted to avoid confusion.

@Chuxel Chuxel added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 6, 2021
@Chuxel
Copy link
Member

Chuxel commented May 6, 2021

@sarisia I assume you're seeing this in Codespaces? If so, that's actually a Codespaces bug.

@sarisia
Copy link
Contributor Author

sarisia commented May 6, 2021

Oh sorry I forgot to note that.

Yes, it happens in GitHub Codespaces.

@Chuxel Chuxel changed the title [docs] Missing step in script-library/docs/desktop-lite.md [upstream] Cannot access noVNC from the web using Codespaces May 6, 2021
@Chuxel
Copy link
Member

Chuxel commented May 25, 2021

A fix for this got tracked down on the GitHub Codespaces side and should be moving into production before too long. Sorry for the trouble!

@Chuxel
Copy link
Member

Chuxel commented May 25, 2021

This should now be resolved in production for Codespaces as well!

@Chuxel Chuxel closed this as completed May 25, 2021
@sarisia
Copy link
Contributor Author

sarisia commented May 25, 2021

Confirmed WebSocket is now working without "Make Public" the port! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug script-library upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants