Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default registry value is not used during docker push #1478

Closed
ravipal opened this issue Dec 10, 2019 · 1 comment · Fixed by #1484
Closed

Default registry value is not used during docker push #1478

ravipal opened this issue Dec 10, 2019 · 1 comment · Fixed by #1484
Assignees
@philliphoff
Labels
bug P3
Milestone
0.10.0

Comments

@ravipal
Copy link
Contributor

ravipal commented Dec 10, 2019

The registries lists shows an option to set a default registry as shown below. I set "MainACR" as default.
image

Then during "Docker Images: Push" again I got the below prompt to save mainacr as default registry.

image
@philliphoff
Copy link
Contributor

The problem is that the extension does not check whether a default already exists before prompting to save a tagged image prefix as the default.

@philliphoff philliphoff self-assigned this Dec 11, 2019
@philliphoff philliphoff added this to the 0.10.0 milestone Dec 11, 2019
@philliphoff philliphoff mentioned this issue Dec 11, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@philliphoff philliphoff

Labels
bug P3
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Only prompt to save registry if no default exists. microsoft/vscode-docker
2 participants
@ravipal @philliphoff