Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete images by name instead of ID #1529

Closed
MRayermannMSFT opened this issue Jan 7, 2020 · 3 comments · Fixed by #1803
Closed

Delete images by name instead of ID #1529

MRayermannMSFT opened this issue Jan 7, 2020 · 3 comments · Fixed by #1803
Milestone

Comments

@MRayermannMSFT
Copy link
Member

While I understand the error, it'd be great if there was a feature that helped me determine what child images were causing this error:

image

@MRayermannMSFT MRayermannMSFT changed the title Help me find dependent child images! Feature to find dependent child images Jan 7, 2020
@philliphoff
Copy link
Contributor

That's a good idea. I could see scanning for and adding a list to the error message itself, though that could get unwieldy. Perhaps an option to group images by base image?

@bwateratmsft
Copy link
Contributor

@MRayermannMSFT @philliphoff I've been working on something I think you're gonna like. Here's a couple screenshots that I think convey the concept:

image

image

@dbreshears dbreshears added the P2 label Mar 24, 2020
@bwateratmsft bwateratmsft removed their assignment Apr 1, 2020
@bwateratmsft bwateratmsft changed the title Feature to find dependent child images Delete images by name instead of ID Apr 9, 2020
@bwateratmsft
Copy link
Contributor

Changed the issue title. The fix we made will delete images by name instead of by ID. There are a couple of implications of this:

  1. If the image is in use by a container, it will be untagged, but "deletion" succeeds. Later, if images are pruned, the now-untagged image will be deleted (no more 409 Conflict errors).
  2. If the image is in use by child images, it will be untagged, but "deletion" succeeds. Later, if the child image is removed, the now-untagged image will be deleted (no more 409 Conflict errors).
  3. If the image is not in use by containers or child images, but there are multiple tags for the image, it will be untagged. The other tags will remain. We have had user feedback that the current deletion--which removes all tags--is awkward.
  4. When the last tag is removed from an image, and there are no containers or child images using it, it will be truly removed.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants