Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request textDocument/semanticTokens failed #2055

Closed
csakaszamok opened this issue Jun 10, 2020 · 11 comments · Fixed by #2146
Closed

Request textDocument/semanticTokens failed #2055

csakaszamok opened this issue Jun 10, 2020 · 11 comments · Fixed by #2146

Comments

@csakaszamok
Copy link

during writing a Dockerfile i get error messages:

[Error - 10:47:31 AM] Request textDocument/semanticTokens failed.
Message: Request textDocument/semanticTokens failed with message: Maximum call stack size exceeded
Code: -32603

@rcjsuen
Copy link
Contributor

rcjsuen commented Jun 10, 2020

@csakaszamok Thank you for your bug report. I presume this bug is not reproducible?

Can you share your Dockerfile? Do you remember what you were changing at the time?

@csakaszamok
Copy link
Author

csakaszamok commented Jun 11, 2020

yes, you can reproduce it with a litte sample Dockerfile:

FROM ubuntu
ENV \
# common variables:
  ENV1=something \
  ENV2=999 

if you remove or move the comment, everything is ok
so it is good:

FROM ubuntu
ENV \
  ENV1=something \
# common variables:
  ENV2=999 

thank you

@rcjsuen
Copy link
Contributor

rcjsuen commented Jun 11, 2020

@csakaszamok Thank you for sharing your Dockerfile. I have opened rcjsuen/dockerfile-language-service#69 to track this.

@csakaszamok
Copy link
Author

Thx

@JoseFMP
Copy link

JoseFMP commented Jun 28, 2020

Still happening over here.

@rcjsuen
Copy link
Contributor

rcjsuen commented Jun 28, 2020

Still happening over here.

Hi, @JoseFMP. You are correct. The bug fix is not in a release yet so you will continue to encounter this issue until then. Thank you for your understanding.

@rcjsuen
Copy link
Contributor

rcjsuen commented Jun 28, 2020

@JoseFMP Would you mind sharing your Dockerfile here so we can ensure that your bug is covered?

@rcjsuen
Copy link
Contributor

rcjsuen commented Jul 11, 2020

Thank you @csakaszamok and @JoseFMP for your bug report. I have opened #2146 to address this.

@bwateratmsft bwateratmsft linked a pull request Jul 13, 2020 that will close this issue
@bwateratmsft bwateratmsft modified the milestones: 1.5.0, 1.4.0 Jul 13, 2020
@bwateratmsft
Copy link
Contributor

We have released Docker 1.4.0 which contains a fix for this.

@khs1994
Copy link

khs1994 commented Jul 24, 2020

FROM alpine

ENV kkk \
        vvv \
        # comment
        # comment
        # comment
        # comment
        vvv2

with one more comment line,show this error message

@rcjsuen
Copy link
Contributor

rcjsuen commented Jul 24, 2020

@khs1994 Thank you for your bug report. I have reproduced the problem and have opened rcjsuen/dockerfile-language-service#74 to track this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants