Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Using port 2376 + No SSL/TLS => Extension cannot establish connection (TLS Failure) #2164

Closed
ntziolis opened this issue Jul 15, 2020 · 2 comments
Labels

Comments

@ntziolis
Copy link

ntziolis commented Jul 15, 2020

While it is pretty standard to use SSL/TLS when port 2376 is specified the extension should not assume this as a given.

When using docker from the command line incl from within vscode) there were no issues when using the same host + port configuration.

When exposing the remote docker host + vscode settings to use port 2375 the extension can connect just fine. No other configuration was changed.

@bwateratmsft
Copy link
Contributor

@ntziolis This is a function of docker-modem which is used by Dockerode in our extension: https://github.com/apocas/docker-modem/blob/master/lib/modem.js#L44

Can you file this issue there? Thanks!

@ntziolis
Copy link
Author

Done, thanks for identifying where this should land instead. Much appreciated.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants