Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no port textbox when adding docker compose files to express app #2495

Closed
v-ruizh opened this issue Nov 17, 2020 · 2 comments · Fixed by #2503
Closed

There is no port textbox when adding docker compose files to express app #2495

v-ruizh opened this issue Nov 17, 2020 · 2 comments · Fixed by #2503
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Nov 17, 2020

OS: Windows 10
Build Version: 20201111.4

Repro Steps:

  1. Create an Express App and add docker files for it.
  2. F1 -> Docker: Add Docker Compose Files to Workspace... -> Node.js -> Choose a package.json file.

Expect:
Navigate to the port textbox, like below screen during adding docker files.
image

Actual:
There is no port textbox when adding docker compose files to to express app.
image

More Info:
This issue does not reproduce for .NET Core project.

@v-ruizh v-ruizh added the AT-CTI label Nov 17, 2020
@bwateratmsft
Copy link
Contributor

I did this on purpose but now I'm having trouble remembering why...

@bwateratmsft
Copy link
Contributor

I think maybe it was just an oversight. Python, .NET, and Java all show the ports prompt during either single-Dockerfile or compose scaffolding.

@bwateratmsft bwateratmsft added this to the 1.9.0 milestone Nov 18, 2020
@bwateratmsft bwateratmsft self-assigned this Nov 18, 2020
@bwateratmsft bwateratmsft removed their assignment Nov 23, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants