Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special code for .NET 2.1- support #3093

Closed
bwateratmsft opened this issue Jul 27, 2021 · 0 comments · Fixed by #3145
Closed

Remove special code for .NET 2.1- support #3093

bwateratmsft opened this issue Jul 27, 2021 · 0 comments · Fixed by #3145

Comments

@bwateratmsft
Copy link
Contributor

On August 21st, support for .NET 2.1 ends, so we can remove code that is needed to support it. For example, this:

} else {
// Otherwise try to manually edit the project file by adding a property group immediately after the <Project> tag
// Allowing for leading and trailing whitespace, as well as XML attributes, this regex matches the <Project> tag as long as it is alone on its line
const projectTagRegex = /^[ \t]*<Project.*>[ \t]*$/im;
const matches = contents.match(projectTagRegex);
if (matches && matches[0]) {
// If found, add the new property group immediately after
const propertyGroup = `
<PropertyGroup>
<UserSecretsId>${cryptoUtils.getRandomHexString(32)}</UserSecretsId>
</PropertyGroup>`;
const newContents = contents.replace(matches[0], matches[0] + propertyGroup);
await fse.writeFile(projectFile, newContents);
}
}
.

@bwateratmsft bwateratmsft added this to the 1.17.0 milestone Jul 27, 2021
@bwateratmsft bwateratmsft self-assigned this Aug 4, 2021
@bwateratmsft bwateratmsft removed their assignment Aug 16, 2021
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant