Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tag format is excessively verbose for local images #3734

Closed
rasmus-e opened this issue Nov 30, 2022 · 6 comments · Fixed by #3735
Closed

Image tag format is excessively verbose for local images #3734

rasmus-e opened this issue Nov 30, 2022 · 6 comments · Fixed by #3735

Comments

@rasmus-e
Copy link

Only images in remote repositories are shown in the IMAGES panel.

I have returned to 1.22.2.
Tests:

  • Reset image "Config Explorer" to default settings (never changed anything);
  • Rebooted, switched to 1.22.2, local images show;
  • Tried 1.23.1 and 1.23.0 again, both have the issue of missing images;
  • Returned to 1.22.2 again - now my images are visible.

(repeated the tests a couple times, result stands)

VsCode on Mac air (2020)

@bwateratmsft
Copy link
Contributor

Can you share a screenshot of both 1.22.2 and 1.23.0?

@rasmus-e rasmus-e changed the title Local images no longer listed after 1.23.0 Local images no longer listed since 1.23.0 Nov 30, 2022
@rasmus-e

This comment was marked as outdated.

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Nov 30, 2022

Thanks @rasmus-e! It looks like the images are still there, under docker.io/file-storage and docker.io/javaworker. But it seems that we are including docker.io in image names when we didn't in 1.22.2.

@rasmus-e
Copy link
Author

Ah, was just hiding the comment cos noticed the same.
I can work with that, no problem you may close the issue as warranted.

Thanks for quick responses, sorry for noise!

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Nov 30, 2022

I think I'd like to change this, so I'll reopen the issue. The old behavior was essentially to not show docker.io or docker.io/library ahead of images which are implicitly in that namespace. This includes common base images (e.g. alpine, for which the most explicit full name would be docker.io/library/alpine), and locally-built images that aren't namespaced or tagged for a registry (e.g. mywebapp, which until it is explicitly namespaced or given a registry, Docker would assume it was meant for docker.io/library).

I'm going to include a very slight change to the old behavior, where an image with a namespace will still implicitly add the docker.io/. e.g. kindest/node:latest will show under docker.io/kindest/node. But, node:latest will just show under node.

@bwateratmsft bwateratmsft reopened this Nov 30, 2022
@bwateratmsft bwateratmsft added this to the 1.23.2 milestone Nov 30, 2022
@bwateratmsft bwateratmsft self-assigned this Nov 30, 2022
@bwateratmsft bwateratmsft removed their assignment Dec 2, 2022
@bwateratmsft bwateratmsft changed the title Local images no longer listed since 1.23.0 Image tag format is excessively verbose for local images Dec 5, 2022
@bwateratmsft
Copy link
Contributor

A fix for this has been released in Docker extension version 1.23.2.

@microsoft microsoft locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants