Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid image name on v1.23.1 #3752

Closed
michaelkourlas opened this issue Dec 7, 2022 · 3 comments · Fixed by #3764
Closed

Invalid image name on v1.23.1 #3752

michaelkourlas opened this issue Dec 7, 2022 · 3 comments · Fixed by #3764

Comments

@michaelkourlas
Copy link

I'm experiencing an issue similar to #3719 in v1.23.1.

Output of docker image ls --format "{{ json . }}" on my remote SSH host:

{"Containers":"N/A","CreatedAt":"2022-07-05 13:43:31 -0400 EDT","CreatedSince":"5 months ago","Digest":"\u003cnone\u003e","ID":"a80cfbd6e315","Repository":"apps-jenkins:18888/devserver-centos8","SharedSize":"N/A","Size":"5.39GB","Tag":"1.0.4","UniqueSize":"N/A","VirtualSize":"5.39GB"}

Please let me know if you need other information.

@bwateratmsft
Copy link
Contributor

Sort of copying my comment from #3719 but I'll include it here for posterity. I think that what's happening is that the image registry is sort of a top-level domain (apps-jenkins), and our code isn't expecting any top-level domains as a registry except for localhost specifically.

@bwateratmsft
Copy link
Contributor

We based our parsing on this StackOverflow answer. I think we misread the requirements slightly--upon rereading it again, it sounds like a registry hostname can be a top-level domain, as long as a : port separator is included. In any case, it's clear that Docker accepted this as a valid image name--else it wouldn't have been tagged this way in the first place--so we need to update our parsing logic.

@danegsta
Copy link
Contributor

A fix for how we're parsing image names has been released in 1.23.3.

@microsoft microsoft locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants