Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native modules update #627

Closed
bpasero opened this issue Oct 4, 2016 · 3 comments
Closed

Native modules update #627

bpasero opened this issue Oct 4, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 4, 2016

Refs: https://code.visualstudio.com/docs/extensions/patterns-and-principles#_common-questions

I see we actually encourage people to use native modules. This is dangerous because every time we update Electron these native modules will not work anymore.

We should strongly advise AGAINST using native modules in extensions after all. And if nothing helps, tell people that each time we release a new version of VS Code they will have to recompile the prebundled native modules against the same node.js version that VS Code ships with.

/cc @egamma

@egamma
Copy link
Member

egamma commented Oct 4, 2016

Suggest to add a warning as @bpasero suggested to the question. We should keep the question.

Notice: native modules bundled with an extension must be recompiled with every new version of VS Code against the same node.js version that VS Code ships with.

We should keep the Common Questin

@bpasero
Copy link
Member Author

bpasero commented Oct 4, 2016

Maybe add that finding out the node.js version and modules version can be done by running process.versions from the developer tools.

@gregvanl gregvanl added this to the October 2016 milestone Oct 4, 2016
@egamma
Copy link
Member

egamma commented Oct 4, 2016

This is the background issue microsoft/vscode#13143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants