Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version of the Emmet module #28

Closed
ramya-rao-a opened this issue Nov 20, 2018 · 4 comments
Closed

Use the latest version of the Emmet module #28

ramya-rao-a opened this issue Nov 20, 2018 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 20, 2018

The master branch at the moment is using version 0.5.10 of expand-abbreviation module with latest version of abbreviation and snippets module. See https://github.com/ramya-rao-a/expand-abbreviation/tree/0.5.10

We should move on to use the latest version of the expand-abbreviation module.

@ramya-rao-a
Copy link
Contributor Author

From Sergey about version 0.6:

Hey Ramya,

just wanted to let you know that I’m going publish some breaking changes in @emmetio/expand-abbreviation module in v0.6

These changes are second argument with options. Moving towards web-based UI for Emmet customization, I’ve refactored and unified options layout for both markup & stylesheet abbreviations.
Also, I’ve created a config specs for customization. This config for storing global preferences and redefine them on syntax and/or project basis: https://github.com/emmetio/config

You can translate VSCode prefs to a config format and then use provided config resolver or simply pass manually resolved config to abbreviation expander with the following format: https://github.com/emmetio/config/blob/master/index.js#L39

@rzhao271 rzhao271 added the feature-request Request for new features or functionality label Oct 6, 2020
@rzhao271 rzhao271 self-assigned this Nov 3, 2020
@rzhao271 rzhao271 changed the title Use the latest version of the expand-abbreviation module Use the latest version of the Emmet module Nov 9, 2020
@rzhao271
Copy link
Contributor

Done. For verification, see package.json in 129f7ec

There may still be bugs to resolve upstream such as emmetio/emmet#638 but we are at least now using the latest Emmet dependency (at this time v2.3.0).

@rzhao271 rzhao271 modified the milestone: January 2021 Jan 25, 2021
@rzhao271
Copy link
Contributor

Reopening since it's still not the actual upstream repo yet.

@rzhao271 rzhao271 reopened this Jan 28, 2021
@rzhao271
Copy link
Contributor

Fixed by 209ed1e
Verify by code review.

@rzhao271 rzhao271 added this to the February 2021 milestone Feb 12, 2021
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Feb 12, 2021
@jrieken jrieken added the verified Verification succeeded label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants