Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule customizations override quiet #1246

Closed
DaveStein opened this issue May 4, 2021 · 3 comments
Closed

Rule customizations override quiet #1246

DaveStein opened this issue May 4, 2021 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@DaveStein
Copy link

I have the following settings:

"eslint.rules.customizations": [
{ "rule": "jest/no-focused-tests", "severity": "warn" },
],
"eslint.quiet": true

I'd expect my error to drop to warn and then eslint.quiet would make sure my editor doesn't highlight the issue anymore.

As it stands, i can't focus a test while doing dev work without having all the UI squiggles under the code. Since customizations is supposed to override a rule for the editor, and I'm overriding to warn, I would expect eslint.quiet to make it hidden given that the description says ignore warnings..

Is this working as intended or a bug that I have found?

@dbaeumer
Copy link
Member

It is actually confusing that we have customizations and quite. The current idea is to deprecate quiet and to allow off in the customizations.

@dbaeumer dbaeumer added this to the 2.2.0 milestone May 10, 2021
@DaveStein
Copy link
Author

@dbaeumer i was actually surprised you didn't have off but didn't think to ask for it for some reason :)

@dbaeumer
Copy link
Member

See #1243 for the PR. I will close the issue then and treat it as a dup of the off severity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants