Quick Fix popup stopped suggesting "Add missing import" for JS

[croraf]

• VS Code Version: 1.59.1
• OS Version: Linux x64 5.4.0-45-generic

Version: 1.59.1
Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa
Date: 2021-08-19T11:54:37.513Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Linux x64 5.4.0-45-generic

Steps to Reproduce:

1. Context:

• have a JS project with package.json with "type": "module" property.
• Have ESLint extension installed, eslint dependency installed locally with npm install eslint
• Have the following eslint configuration file .eslintrc.cjs:

module.exports = {
  'env': {
    'node': true,
    'es2021': true,
  },
  'extends': 'eslint:recommended',
  'parserOptions': {
    'ecmaVersion': 12,
    'sourceType': 'module'
  },
  'rules': {
  }
};

2. have two JS files first.js and second.js

// second.js
const myItem = 5;
export {myItem};

// first.js
const temp = myItem;

During typing of myItem in first.js the editor does suggest me to complete it and import, and on confirm it does complete and import myItem. (this part works even without ESLint extension and library)

But, if it is already completed, it does get underlined as a missing error and you can open a Quickfix popup. But in the Quickfix popup there is no suggestion to "Add the missing import".

The "Add the missing import" suggestion was present until sometime in the mid 2021. (But perhaps I disabled something in the settings also.)

[croraf]

This is a copy of this issue opened on the vscode repository: microsoft/vscode#131840

[dbaeumer]

I am not sure what exactly the issue is. Running eslint in the terminal shows exactly the same errors than the eslint extension does

dirkb:~/Projects/../1326 $ ./node_modules/.bin/eslint first.js

/home/dirkb/Projects/playgrounds/1326/first.js
  2:7   error  'temp' is assigned a value but never used  no-unused-vars
  2:14  error  'myItem' is not defined                    no-undef

✖ 2 problems (2 errors, 0 warnings)

[croraf]

Yes.

But the problem is in the Quick Fix feature. When error popup shows up, in its bottom right corner you have a Quick Fix link which opens another popup with suggested fixes. (As shown in the images)

The Quick Fix popup should suggest to add the missing import but it does not since 2 months ago (but perhaps is a problem in my settings.

The "Fix this semi problem" for example is shown correctly as before:

[dbaeumer]

When you run eslint in the terminal with the --fix option doe the problem get fixed. If not it is not fixable in the extension either. This can be a configuration problem or something ESLint itself doesn't support anymore.

[croraf]

I actually tried that later yesterday, and it does not get fixed. This is what suggested me that it has nothing to do with vscode-eslint extension, because the extension just forwards the autofixable things to the vscode, right?

If this is the case then perhaps eslint removed the support for this, or vscode provided the autoimport fix through "typescript language features" or I have some configuration issue.

I mean vscode-eslint hasn't released a new production version since 2020, right? And the issue started to appear mid 2021.

[dbaeumer]

The latest update on vscode-eslint is from 6/15/2021. Since eslint on the terminal doesn't fix the issue either there is little I can do to fix this. If you ask me the fix came from TypeScript and not from ESLint itself since ESLint is usually single file and wouldn't know from where to import the symbol from.

[dbaeumer]

I will close the issue.

[croraf]

The latest update on vscode-eslint is from 6/15/2021.

Oh, I see now in the marketplace docs. But here on the github, in code tab it says:

Since eslint on the terminal doesn't fix the issue either there is little I can do to fix this. If you ask me the fix came from TypeScript and not from ESLint itself since ESLint is usually single file and wouldn't know from where to import the symbol from.

Makes sense for now.

[kbridge]

It's almost 2023 and this problem still seems not fixed yet.

[dbaeumer]

As said this need to be fixed in TS/JS and not in ESLint.

[Pefington]

This works for me: add // @ts-check at the beginning of the file.