Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all auto-fixable Problems doesn't yield the same result as eslint file.js --fix #823

Closed
mmahdigh opened this issue Dec 6, 2019 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@mmahdigh
Copy link

mmahdigh commented Dec 6, 2019

I have configured ESLint for an already written project, but the problem is when I click Fix all auto-fixable Problems it doesn't do a great job of fixing indents whereas running eslint file.js --fix does it well (to be precise sometimes after two times of running it ).

Below is a code sample with which Fix all auto-fixable Problems doesn't work well:

    <LanguageContext.Consumer>
        {(value) => {
            const vocabs = getTranslator(value.language);
            return (
                <Grid container direction="row"
                      justify="center" alignItems="center">
                    <ButtonGroup size={"small"}>
                        <Button variant={props.authFormState === 'login' ? 'contained' : 'outlined'} color='primary'
                                className={props.authFormState === 'login' ? classes.disabledButtonRight : classes.switchButtonRight}
                                onClick={changeFormStateToLogin}>
                            {vocabs('login')}
                        </Button>
                        <Button variant={props.authFormState === 'register' ? 'contained' : 'outlined'} color='primary'
                                className={props.authFormState === 'register' ? classes.disabledButtonLeft : classes.switchButtonLeft}
                                onClick={changeFormStateToRegister}>
                            {vocabs('register')}
                        </Button>
                    </ButtonGroup>
                </Grid>
            )
        }}
    </LanguageContext.Consumer>
@dbaeumer
Copy link
Member

dbaeumer commented Dec 9, 2019

This got addressed for the next version of ESLint. Pls see #815 if you want to help test this.

@dbaeumer dbaeumer added this to the 2.0.0 milestone Dec 9, 2019
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Dec 9, 2019
@dbaeumer
Copy link
Member

2.0.4 now shipped.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants