Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode does not use rules in .eslintrc.js #866

Closed
ahuigo opened this issue Jan 3, 2020 · 3 comments
Closed

vscode does not use rules in .eslintrc.js #866

ahuigo opened this issue Jan 3, 2020 · 3 comments
Labels
info-needed Issue requires more information from poster

Comments

@ahuigo
Copy link

ahuigo commented Jan 3, 2020

I have set .eslintrc.js to ignore some rules.

module.exports = {
    rules: {
        '@typescript-eslint/no-unused-vars': 'off',
   }
};

eslint command works well

$ npx eslint --ext .js,.jsx,.ts,.tsx  "test.tsx"

But vs code ignore these rules.

image

Here is my repo example

https://github.com/ahuigo/vscode-eslint-react-ts

@dbaeumer
Copy link
Member

dbaeumer commented Jan 6, 2020

@ahuigo can you please add your ESLint version and plugins to the package.json of the provided test project. Otherwise it is very hard for me to reproduce the problem since it depends on some global configuration you are using.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Jan 6, 2020
@ahuigo
Copy link
Author

ahuigo commented Jan 7, 2020

Here is my full test project with eslint version:

https://github.com/ahuigo/vscode-eslint-react-ts/tree/88a1538d3ea40d0918c5974639a6d61e92ec6290

git clone https://github.com/ahuigo/vscode-eslint-react-ts
cd vscode-eslint-react-ts && yarn
npx eslint --ext .js,.jsx,.ts,.tsx  src/test.tsx

@dbaeumer
Copy link
Member

dbaeumer commented Jan 7, 2020

@ahuigo actually the errors you are seeting are from the TypeScript extension not from ESLint. The code is ts(6133). All ESLint error codes start with eslint

@dbaeumer dbaeumer closed this as completed Jan 7, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants