Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: "Cannot read property 'source.fixAll.eslint' of null" #945

Closed
andrao opened this issue Apr 15, 2020 · 1 comment
Closed

Error: "Cannot read property 'source.fixAll.eslint' of null" #945

andrao opened this issue Apr 15, 2020 · 1 comment
Assignees
Labels
info-needed Issue requires more information from poster
Milestone

Comments

@andrao
Copy link

andrao commented Apr 15, 2020

This issue has come up with the latest version – 2.1.3:

image

I reckon it's caused by the new CodeActionsOnSave.isExplicitlyDisabled() function here: 5d3bc85#diff-bc3c0f2fe3aca9ddbe96347ffb00641eR466-R471, which doesn't account for the case where setting is null.

Through no deliberate action of my own, my User-level settings were updated to include:

{
   // ...
   "editor.codeActionsOnSave": null
}

Again I'm unsure as to why this happened – it wasn't a manual edit. I am indeed told that null is an invalid value when viewing my settings file:

image

May be common enough to warrant a fix.


Issue is resolved by reverting to 2.1.2.

@dbaeumer
Copy link
Member

@andrao How do your user level and workspace level settings look like when this happend?

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Apr 16, 2020
@dbaeumer dbaeumer self-assigned this Apr 16, 2020
@dbaeumer dbaeumer modified the milestones: 2.1.3, 2.1.4 Apr 16, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants