Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common properties not sent when properties parameter is undefined in sendTelemetryEvent #149

Closed
jwunderl opened this issue Mar 16, 2023 · 1 comment · Fixed by microsoft/vscode#178847
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@jwunderl
Copy link
Member

jwunderl commented Mar 16, 2023

Telemetry events sent through TelemetryReporter.sendTelemetryEvent with just the eventName parameter (/ undefined for properties) do not include the common properties like common.extname; e.g. comparing two ticks

tr.sendTelemetryEvent("shareProject");

image

vs.

tr.sendTelemetryEvent("duplicateAsset", {});

image

I would expect it to always fill in the common properties.

Thanks~

@lramos15
Copy link
Member

Thanks for the report, if you get a chance please verify this works as expected in Mondays insiders build. The fix is upstream so you will not need to update your module at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants